Skip to content

Cherrypick #3461 for release/2.7 #3464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2025
Merged

Cherrypick #3461 for release/2.7 #3464

merged 1 commit into from
Apr 5, 2025

Conversation

zewenli98
Copy link
Contributor

Description

Cherrypick #3461 for release/2.7

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 self-assigned this Apr 4, 2025
@github-actions github-actions bot added component: core Issues re: The core compiler component: api [Python] Issues re: Python API component: runtime component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Apr 4, 2025
@github-actions github-actions bot requested a review from peri044 April 4, 2025 21:17
Copilot
Copilot AI reviewed Apr 4, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • core/runtime/TRTEngine.cpp: Language not supported
  • core/runtime/TRTEngine.h: Language not supported
  • core/runtime/register_jit_hooks.cpp: Language not supported
Comments suppressed due to low confidence (1)

py/torch_tensorrt/dynamo/runtime/meta_ops/register_meta_ops.py:145

  • The method 'reset_captured_graph' is currently a no-op, which may lead to unexpected behavior. If this is intentional, please add a comment or a TODO to clarify its purpose.
def reset_captured_graph(self) -> Any:

@zewenli98 zewenli98 merged commit 0862749 into release/2.7 Apr 5, 2025
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@narendasan narendasan Awaiting requested review from narendasan

@keehyuna keehyuna Awaiting requested review from keehyuna

@peri044 peri044 Awaiting requested review from peri044

Assignees

@zewenli98 zewenli98

Labels
cla signed component: api [Python] Issues re: Python API component: core Issues re: The core compiler component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zewenli98 @facebook-github-bot